Reapply Active Filters when Opening Music Library#1548
Open
Dansla116 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When profiles or instruments changed, Music Library could show songs that no longer matched the previous Filters menu state. The Filters menu still showed the selections as active, but the library list was rebuilt without applying them.
Previously, active filters were refreshed from profile-change handling, which covered returning from Difficulty Select but missed other Music Library entry paths like Score Results. This updates Music Library to rebuild the active filter predicate in
MusicLibraryMenu.OnEnable()before refreshing the song list, so saved filters are consistently reapplied whenever the library opens.This fixes: https://discord.com/channels/1086048856678084609/1514015970740666429
Potential Feedback Item:
I removed re-applying the filters from
PlayerContainer.ActiveProfilesChanged()because I couldn't find a way to change profiles/instruments without then triggeringMusicLibraryMenu.OnEnable()so it seemed redundant. Let me know if I missed something. Otherwise, this might still need to be added back with upcoming profile/controller "Overshell" changes.